Re: [PATCH v3 3/4] bisect--helper: reimplement `bisect_run` shell function in C

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 11, 2021, 20:33 UTC
Message-ID: <xmqqtuocfto7.fsf@gitster.g>
In-Reply-To: <xmqqy2doftrj.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 7 quoted lines

> Miriam Rubio <mirucam@gmail.com> writes:
>
>> +		if (res < 0 || 128 <= res) {
>> +			error(_("bisect run failed: exit code %d from"
>> +				" '%s' is < 0 or >= 128"), res, command.buf);
>
> Good now.

Oh, while asking for better test coverage, it is somewhat surprising that the broken error condition check in v2 was never noticed. Can we add a test for this, too?

Thanks.