git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] completion: tcsh: Fix regression by drop of wrapper functions

From
Junio C Hamano <gitster@pobox.com>
Date
Aug 18, 2021, 20:57 UTC
Message-ID
<xmqqtujm4gjw.fsf@gitster.g>
In-Reply-To
<20210818132729.26021-1-tiwai@suse.de>
Takashi Iwai <tiwai@suse.de> writes:
Show 9 quoted lines
> The cleanup of old compat wrappers in bash completion caused a
> regression on tcsh completion that still uses them.
> Let's update the tcsh call site as well for addressing it.
>
> Fixes: 441ecdab37fe ("completion: bash: remove old compat wrappers")
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>  contrib/completion/git-completion.tcsh | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
Thanks.  Will queue.
Show 16 quoted lines
> diff --git a/contrib/completion/git-completion.tcsh b/contrib/completion/git-completion.tcsh
> index 4a790d8f4ec1..ba797e5b3cd5 100644
> --- a/contrib/completion/git-completion.tcsh
> +++ b/contrib/completion/git-completion.tcsh
> @@ -80,8 +80,9 @@ else
>  	COMP_CWORD=\$((\${#COMP_WORDS[@]}-1))
>  fi
>  
> -# Call _git() or _gitk() of the bash script, based on the first argument
> -_\${1}
> +# Call __git_wrap__git_main() or __git_wrap__gitk_main() of the bash script,
> +# based on the first argument
> +__git_wrap__\${1}_main
>  
>  IFS=\$'\n'
>  if [ \${#COMPREPLY[*]} -eq 0 ]; then
Previous: Takashi Iwai
Message 2 of 2 in “completion: tcsh: Fix regression by drop of wrapper functions”
  1. completion: tcsh: Fix regression by drop of wrapper functionsTakashi Iwai, Aug 18, 2021
  2. Junio C HamanoAug 18, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.