Re: [PATCH V3 1/2] patch-id: Fix antipatterns in tests

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 1, 2022, 23:18 UTC
Message-ID: <xmqqtudi9nwq.fsf@gitster.g>
In-Reply-To: <d9275c31-7558-fc9c-9eb3-2a0cb81a8259@kdbg.org>

Johannes Sixt <j6t@kdbg.org> writes:

>> +	calc_patch_id nonl <nonl &&
>> +	calc_patch_id withnl <withnl &&
>
> ... you could in fact just redirect the here-documents into these commands.

That was part of my original suggestion, and then I realized that nonl and withnl may later be reused and rewrote it before sending my review comment.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.