Re: [PATCH] commit: fix "author_ident" leak

From: Junio C Hamano <gitster@pobox.com>
Date: May 18, 2022, 16:30 UTC
Message-ID: <xmqqtu9mx0p7.fsf@gitster.g>
In-Reply-To: <220517.86fsl86z1s.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> But even accounting for that, I don't see what the "more maintainable"
> here refers to. The approach I suggested would s/UNLEAK/strbuf_release/
> in the 4th hunk, but otherwise be equivalent.

Judicious use of UNLEAK() has documentation value to tell readers which use of pointer variables need to be explicitly released, and which pointer variables can just implicitly released by going out of scope at the end. There are also a few other small added benefits (they do not have to be changed when the helper needed to do the real release changes, and not doing an explicit real release on resources when there no need to is conceptually cleaner). But they are icing on the cake.

Sorry for a late reply---I go offline every other Tuesday and yesterday was such a Tuesday.