Re: [GSOC][PATCH] Userdiff: add builtin patterns for JavaScript.

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 28, 2024, 18:19 UTC
Message-ID: <xmqqttlsjvsi.fsf@gitster.g>
In-Reply-To: <20240228150034.313196-1-sergiusnyah@gmail.com>

Sergius Nyah <sergiusnyah@gmail.com> writes:

Show 7 quoted lines

> This commit introduces builtin patterns for JavaScript in userdiff and adds a new test
> case in t4018-diff-funcname.sh to verify the enhanced JavaScript function detection in Git diffs.
> Signed-off-by: Sergius Justus Chesami Nyah <sergiusnyah@gmail.com>
> ---
> ...-PATCH-1-2-Add-builtin-patterns-for-.patch | 53 ++++++-------------
> t/t4018-diff-funcname.sh                      | 25 ++++++++-
> 2 files changed, 38 insertions(+), 40 deletions(-)

You apparently have done "git add" of a file that is a format-patch output, which led to ...

> diff --git a/Pattern/0001-Subject-GSOC-RFC-PATCH-1-2-Add-builtin-patterns-for-.patch b/Pattern/0001-Subject-GSOC-RFC-PATCH-1-2-Add-builtin-patterns-for-.patch
> index 43593866bc..9c3b80665e 100644
> --- a/Pattern/0001-Subject-GSOC-RFC-PATCH-1-2-Add-builtin-patterns-for-.patch
> +++ b/Pattern/0001-Subject-GSOC-RFC-PATCH-1-2-Add-builtin-patterns-for-.patch

... this thing.

Wrap the proposed commit log message to a reasonable length and have a blank line before your sign-off. Other pieces of advice about formatting and contents found in Documentation/SubmittingPatches are also helpful.

Thanks.