Re: [PATCH 03/22] t/lib-cvs.sh: avoid redundant use of cat
"Beat Bolli" <bb@drbeat.li> writes:
Show 20 quoted lines
> Signed-off-by: Beat Bolli <dev+git@drbeat.li>
> ---
> t/lib-cvs.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/t/lib-cvs.sh b/t/lib-cvs.sh
> index 32b347337908..57b9b2db9b3f 100644
> --- a/t/lib-cvs.sh
> +++ b/t/lib-cvs.sh
> @@ -71,8 +71,8 @@ test_cmp_branch_tree () {
> find . -type d -name .git -prune -o -type f -print
> ) | sort >module-git-"$1".list &&
> test_cmp module-cvs-"$1".list module-git-"$1".list &&
> - cat module-cvs-"$1".list | while read f
> + while read f
> do
> test_cmp_branch_file "$1" "$f" || return 1
> - done
> + done <module-cvs-"$1".list
> }Again, trivially correct.