Re: [PATCH v2 4/5] t1300: add more tests for whitespace and inline comments

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 18, 2024, 04:38 UTC
Message-ID: <xmqqttl4kvch.fsf@gitster.g>
In-Reply-To: <CAPig+cTLrsUpvKVjkFUgs1b1gvj54rm6FBa=5v3uoQtJnB4rZQ@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 7 quoted lines

>> >> +       x_to_tab >.git/config <<-\EOF
>> >> +       [section]
>> >> +               Xsolid = rock
>> >> +               Xsparse = big XX blue
>> >> +               ...
>> >> +       EOF
>> >> +'

Just this part.

Show 9 quoted lines

> My assumption, perhaps incorrectly, was that existing tests already
> verified correct behavior of leading whitespace and that the tests
> added by this patch were about internal whitespace. If that's not the
> case (and perhaps I didn't fully digest the commit message) then my
> question about the leading "X" is off the mark.
>
> If these new tests are also checking leading whitespace behavior, then
> to improve coverage, would it make sense to have the leading "X" on
> some lines but not others?

If "<<-" (I have here-doc but please strip the leading tabs because I am aligning the here-doc with them) gets in the way for testing material with leading tabs, the way to write and preprocess such a here-doc is:

	sed -e 's/^|//' -e 's/Q/   /g' >.git/config <<-\EOF
	|[section]
	|	solid = rock
	|	sparse = big QQ blue
	|	...
	EOF

It will make it clear where the left-edge of the "sheet of paper" is, removal of leading '|' does not get in the way of using '|' in the middle of the line if needed, and Q being the least used letter makes them stand out more in the middle of the line. As it is obvious that what is before solid and sparse is a tab (otherwise you would not be using that '|' trick), you do not have to write Xsolid or Qsolid there and still the result is much easier to read.