Re: [Outreachy][PATCH 2/2] Port helper/test-date.c to unit-tests/t-date.c

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 28, 2024, 16:35 UTC
Message-ID: <xmqqttkquxes.fsf@gitster.g>
In-Reply-To: <tpaamfc3g5mrrbfufyvxi67ja2ko2hiihrptwxkbmdx4qpid3f@7aashrngiscn>

Ghanshyam Thakkar <shyamthakkar001@gmail.com> writes:

Show 11 quoted lines

> I believe the issue might not be related to the setenv function, but rather
> with tzset(). As you can see here[1], when we set TZ before we call the
> unit-testing binaries, the tests which were failing (EST5 ones that I
> separated with t-datetest) pass on 'win test (0)', and the ones which
> were passing (UTC ones, t-date) fail. (Although some tests on linux are also
> failing, but that can be explained by the fact that t-date runs first
> and sets the TZ to UTC, afterwhich t-datetest runs and fails, although
> this is not conclusive). Therefore, I am almost certain that the issue
> is with changing the timezone during runtime on windows and not with setting
> TZ variable with setenv(). CC'ing Johannes to see if he has any insights
> on this.

Interesting. Sometime before I started working on Git, I learned that no program did tzset() after it started running to switch multiple timezones and worked correctly on many different variants of UNIXes (there were many of them back then), and because I never got interested in writing a world-clock program, I didn't know, and kind of surprised to learn that it works on some platforms (like Linux and macOS) to switch zones with tzset() these days ;-).

So, if Windows runtime is unhappy with the program calling tzset() more than once, I wouldn't be too surprised.

Thanks.