Re: [PATCH v4 08/16] pkt-line: fix -Wsign-compare warning on 32 bit platform

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 9, 2024, 00:09 UTC
Message-ID: <xmqqttbdra2o.fsf@gitster.g>
In-Reply-To: <20241208195703.GA1231962@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> ... Whenever I think "but no callers
> do X", I always try to double-check: "might new callers want to do X"?
> And in this case, I think the answer is "no".

A very good piece of advice for those who are watching from sidelines. I agree that a return value that tries to tell more than "yup, I read everything as instructed" would not help in this case.

Show 12 quoted lines

> They are asking to read a
> whole packet, and it is an error if we don't come up with whole thing.
> Showing the partial garbage we did get is unlikely outside of debug
> tracing (and in that case we'd probably put the tracing inside this
> function anyway).
>
>>  pkt-line.c | 20 +++++++++++---------
>>  1 file changed, 11 insertions(+), 9 deletions(-)
>
> The patch itself looks good.
>
> -Peff