git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/9] t/unit-tests: adapt lib-reftable{c,h} helper functions to clar

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 29, 2025, 15:44 UTC
Message-ID
<xmqqtt677z1r.fsf@gitster.g>
In-Reply-To
<aBB6vHl5Gmtva7b3@pks.im>
Patrick Steinhardt <ps@pks.im> writes:
Show 10 quoted lines
> We do want the Git history to be fully bisectable so that it is easy for
> contributors to find out where a specific bug has been introduced. And
> for the history to be bisectable, we must ensure that every single
> commit builds and passes our test suite. You can do that e.g. via `git
> rebase $BASE_COMMIT -x 'make -j$(nproc) test`, which builds and tests
> every single commit in your commit series.
>
> So yes, this should be adapted so that the initial commit introduces the
> new helpers without removing the old helpers yet so that the unit tests
> that haven't yet been converted continue to build and test just fine.

I started writing the same and thought somebody else may have already responded, and found yours. Very well said.

Thanks for spelling out the expectations we have in this project and explaining how to achieve that goal.

Previous: Patrick SteinhardtNext: Seyi Kuforiji
Message 6 of 14 in “t/unit-tests: convert unit-tests to use clar”
  1. 0/9 t/unit-tests: convert unit-tests to use clarSeyi Kuforiji, Apr 27, 2025
  2. 1/9 t/unit-tests: adapt lib-reftable{c,h} helper functions to clarSeyi Kuforiji, Apr 27, 2025
  3. Junio C HamanoApr 28, 2025
  4. Seyi ChamberApr 29, 2025
  5. Patrick SteinhardtApr 29, 2025
  6. Junio C HamanoApr 29, 2025
  7. 2/9 t/unit-tests: convert reftable basics test to use clar test frameworkSeyi Kuforiji, Apr 27, 2025
  8. 3/9 t/unit-tests: convert reftable block test to use clarSeyi Kuforiji, Apr 27, 2025
  9. 4/9 t/unit-tests: convert reftable merged test to use clarSeyi Kuforiji, Apr 27, 2025
  10. 5/9 t/unit-tests: convert reftable pq test to use clarSeyi Kuforiji, Apr 27, 2025
  11. 6/9 t/unit-tests: convert reftable reader test to use clarSeyi Kuforiji, Apr 27, 2025
  12. 7/9 t/unit-tests: convert reftable readwrite test to use clarSeyi Kuforiji, Apr 27, 2025
  13. 8/9 t/unit-tests: convert reftable record test to use clarSeyi Kuforiji, Apr 27, 2025
  14. 9/9 t/unit-tests: convert reftable stack test to use clarSeyi Kuforiji, Apr 27, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.