Re: [PATCH] mailmap: add an entry for Phillip Wood

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 20, 2026, 18:26 UTC
Message-ID: <xmqqtswgywb4.fsf@gitster.g>
In-Reply-To: <5a4e7da4-d295-4beb-9f37-b2ce4e10df35@app.fastmail.com>

"Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com> writes:

Show 13 quoted lines

> On Tue, Jan 20, 2026, at 12:01, Phillip Wood wrote:
>> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>>
>> While all my commits appear under the same address, other addresses
>> appear in some commit trailers. Map those addresses to the canonical
>> one.
>>
>> Signed-off-by: Phillip Wood <phillip.wood@dunelm.org.uk>
>> ---
>> I'm not sure if we actually remap the address in trailers but
>> we've certainly talked about doing it in the past.
>
> Yeah it does.

Hmph, are you sure? My quick experiment tells me that the trailers are not munged.

    $ git show --pretty=fuller -s | grep '@'
    Author:     Patrick Steinhardt <ps@pks.im>
    Commit:     Junio C Hamano <gitster@pobox.com>
        Signed-off-by: Patrick Steinhardt <ps@pks.im>
        Signed-off-by: Junio C Hamano <gitster@pobox.com>
    $ cat >>.mailmap <<\EOF
    Junio C Hamano <no-such-user@google.com> <gitster@pobox.com>
    EOF
    $ git show --pretty=fuller -s | grep '@'
    Author:     Patrick Steinhardt <ps@pks.im>
    Commit:     Junio C Hamano <no-such-user@google.com>
        Signed-off-by: Patrick Steinhardt <ps@pks.im>
        Signed-off-by: Junio C Hamano <gitster@pobox.com>

By the way, this is totally expected as there is no guarantee that what comes after these colons would look like a human-readable-name followed by an e-mail address at all. Some projects deliberately omit e-mail addresses from reporter credits to protect themselves in jurisdiction with stronger privacy laws, some trailers like "closes:" do not even point at people, etc.

Or perhaps your "Yeah" is about "we've talkined about doing it"?