Re: [PATCH 0/3] [doc] Remove gittutorial-2

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 30, 2026, 14:22 UTC
Message-ID: <xmqqtsn6ddk7.fsf@gitster.g>
In-Reply-To: <20260930061524.GNkIK%taahol@utu.fi>

Tuomas Ahola <taahol@utu.fi> writes:

Show 26 quoted lines

>> Sorry, but there was another.  With this merged, doc-lint seems to
>> fail and breaks 'seen'.
>> 
>>             ...
>>             LINT DOCSTYLE includes/cmd-config-section-all.adoc
>>         no link: gittutorial-2
>>         gmake[1]: *** [Makefile:537: lint-docs-manpages] Error 1
>>         gmake[1]: Leaving directory '/home/gitster/w/buildfarm/seen/Documentation'
>>         gmake: *** [Makefile:4003: check-docs] Error 2
>> 
>
> If we want to build gittutorial-2(7) as a manpage stub but to hide it in `git
> help --guides`, we can squelch that linter error with a merge-fix:
>
> diff --git a/Documentation/lint-manpages.sh b/Documentation/lint-manpages.sh
> index d4a1977ba6..db2a54116d 100755
> --- a/Documentation/lint-manpages.sh
> +++ b/Documentation/lint-manpages.sh
> @@ -32,6 +32,7 @@ check_missing_docs () (
>  		git-legacy-*) continue;;
>  		git-?*--?* ) continue ;;
>  		gitweb.conf) continue ;;
> +		gittutorial-2) continue ;;
>  		esac
>  
>  		if ! test -f "$v.adoc"

Great.  Will use that in future integration runs.

How close is your topic to 'next', by the way? I think we have already caught a few missing links since it was queued in 'seen', and that should be enough to prove its worth. Even so, that is merely "we saw cases where it was useful" and neither "we know it will not fire when it should not" and nor "we know it will always fire when it should" (which is why we want to see a solid review).

What I am wondering is if Julia's topic should be built on top of the ta/command-list-guides-sync-lint topic. Perhaps it is a bad idea and coping with merge-fix would be more flexible.

Thanks.