git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] pack-objects: do not reuse packfiles without --delta-base-offset

From
Junio C Hamano <gitster@pobox.com>
Date
Apr 4, 2014, 22:28 UTC
Message-ID
<xmqqsipsohjz.fsf@gitster.dls.corp.google.com>
In-Reply-To
<20140404214848.GA23666@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
> We could convert OFS_DELTA to REF_DELTA on the fly. That _may_ have a
> performance impact. Right now, we are basically doing the equivalent of
> sendfile(), and conversion would involve iterating through each object
> and examining the header.  I think that's probably not too bad, though.
> The most expensive part of that, stepping to the next object, requires
> scanning through the zlib packets, but we should be able to use the
> revidx to avoid that.
>
> I'm not sure it's even worth the code complexity, though. The non-reuse
> codepath is not that much slower, and it should be extremely rare for a
> client not to support OFS_DELTA these days.

OK, together with the fact that only ancient versions of fetcher would trigger this "do not reuse" codepath, I agree that we should go the simplest route this patch takes.

Thanks.
Previous: Jeff KingNext: Jeff King
Message 4 of 6 in “pack-objects: do not reuse packfiles without --delta-base-offset”
  1. pack-objects: do not reuse packfiles without --delta-base-offsetJeff King, Apr 2, 2014
  2. Junio C HamanoApr 2, 2014
  3. Jeff KingApr 4, 2014
  4. Junio C HamanoApr 4, 2014
  5. Jeff KingApr 4, 2014
  6. Junio C HamanoApr 7, 2014

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.