Re: [PATCH] pack-objects: do not reuse packfiles without --delta-base-offset
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Apr 4, 2014, 22:28 UTC
- Message-ID
- <xmqqsipsohjz.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <20140404214848.GA23666@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 11 quoted lines
> We could convert OFS_DELTA to REF_DELTA on the fly. That _may_ have a > performance impact. Right now, we are basically doing the equivalent of > sendfile(), and conversion would involve iterating through each object > and examining the header. I think that's probably not too bad, though. > The most expensive part of that, stepping to the next object, requires > scanning through the zlib packets, but we should be able to use the > revidx to avoid that. > > I'm not sure it's even worth the code complexity, though. The non-reuse > codepath is not that much slower, and it should be extremely rare for a > client not to support OFS_DELTA these days.
OK, together with the fact that only ancient versions of fetcher would trigger this "do not reuse" codepath, I agree that we should go the simplest route this patch takes.
Thanks.