Re: [PATCH] run_diff_files: do not look at uninitialized stat data

From: Junio C Hamano <gitster@pobox.com>
Date: May 15, 2014, 16:37 UTC
Message-ID: <xmqqsiobgfq9.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20140514221306.GA5020@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 13 quoted lines

> Thanks for a thorough bug report. I was able to reproduce it. The
> ...
> -- >8 --
> Subject: run_diff_files: do not look at uninitialized stat data
> ...
> We can fix both by splitting the CE_VALID and regular code
> paths, and making sure only to look at the stat information
> in the latter. Furthermore, we push the declaration of our
> "struct stat" down into the code paths that actually set it,
> so we cannot accidentally access it uninitialized in future
> code.
>
> Signed-off-by: Jeff King <peff@peff.net>

Thanks for an excellent work, as always.  Will queue.