git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] t1020: cleanup subdirectory tests a little

From
Junio C Hamano <gitster@pobox.com>
Date
May 18, 2015, 18:30 UTC
Message-ID
<xmqqsiatbuwb.fsf@gitster.dls.corp.google.com>
In-Reply-To
<xmqqwq05buz1.fsf@gitster.dls.corp.google.com>
Junio C Hamano <gitster@pobox.com> writes:
Show 15 quoted lines
> Stefan Beller <sbeller@google.com> writes:
>
>> When looking through existing tests to point out good style I came across
>> t1020, which has a test commented out and the comment wasn't helping me
>> either of what the test should accomplish in the future. The code of the
>> test is the same as the test before except setting GIT_DIR=. explicitly,
>> so it did not ring a bell for me as well.
>
> I think this one should be clear, especially if you did notice the
> one that sets GIT_DIR=. explicitly.  It is saying that "git show -s
> HEAD" inside the bare repository should be intelligent enough to
> realize that it is inside bare repository (hence HEAD cannot be a
> file in the working tree); the user's asking for "HEAD" therefore
> must mean "the tip commit", and never "(by default the tip commit)
> filtered to the pathspec HEAD".

I forgot to conclude that sentence: "... and it should be able to do so without the help of an explicit GIT_DIR=."

> If it does not still work, shouldn't it be marked as
> test_expect_failure instead of being commented out?
Previous: Junio C HamanoNext: Stefan Beller
Message 3 of 10 in “t1020: cleanup subdirectory tests a little”
  1. t1020: cleanup subdirectory tests a littleStefan Beller, May 18, 2015
  2. Junio C HamanoMay 18, 2015
  3. Junio C HamanoMay 18, 2015
  4. Stefan BellerMay 18, 2015
  5. Junio C HamanoMay 18, 2015
  6. subdirectory tests: code cleanup, uncomment testStefan Beller, May 18, 2015
  7. Junio C HamanoMay 18, 2015
  8. Stefan BellerMay 18, 2015
  9. Jonathan NiederMay 18, 2015
  10. Junio C HamanoMay 19, 2015

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.