Re: [PATCH v2 4/4] git gui: allow for a long recentrepo list

From: Junio C Hamano <gitster@pobox.com>
Date: Dec 17, 2015, 19:32 UTC
Message-ID: <xmqqsi30c1lk.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <1450310287-4936-5-git-send-email-philipoakley@iee.org>

Philip Oakley <philipoakley@iee.org> writes:

Show 8 quoted lines

> The gui.recentrepo list may be longer than the maxrecent setting.
> Allow extra space to show any extra entries.
>
> In an ideal world, the git gui would limit the number of entries
> to the maxrecent setting, however the recentrepo config list may
> have been extended outside of the gui, or the maxrecent setting changed
> to a reduced value. Further, when testing the gui's recentrepo
> logic it is useful to show these extra, but valid, entries.

I do not have a strong objection either way, but the magic number 5 smells like an indication that this is solving a wrong problem or solving a problem in a wrong approach. What happens to the entries beyond $maxrecent-th in the recent list with the current code? The list effectively truncated and not shown? Wouldn't the same thing happen to the entries beyond ($maxrecent+5)-th in the recent list with your patch?

Truncating the list at $maxrecent-th to match the display (i.e. declare that "$maxrecent" is really the max number of entries we would keep track of), or allowing the UI to scroll so that entries beyond $maxrecent-th one can be shown, perhaps?

Show 22 quoted lines

>
> Signed-off-by: Philip Oakley <philipoakley@iee.org>
> ---
> word usage corrected.
> Eric's comments $gmane/282432
> ---
>  git-gui/lib/choose_repository.tcl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/git-gui/lib/choose_repository.tcl b/git-gui/lib/choose_repository.tcl
> index ad7a888..a08ed4f 100644
> --- a/git-gui/lib/choose_repository.tcl
> +++ b/git-gui/lib/choose_repository.tcl
> @@ -153,7 +153,7 @@ constructor pick {} {
>  			-background [get_bg_color $w_body.recentlabel] \
>  			-wrap none \
>  			-width 50 \
> -			-height $maxrecent
> +			-height [expr {$maxrecent + 5}]
>  		$w_recentlist tag conf link \
>  			-foreground blue \
>  			-underline 1