git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] tag: do not show ambiguous tag names as "tags/foo"

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 25, 2016, 02:26 UTC
Message-ID
<xmqqsi1m9yxh.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20160124222736.GA29115@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
> Yeah, "strip=2" would also get the job done, and extends more naturally
> to the branch case.
>
> To be honest, I cannot imagine anybody using anything _but_ strip=2...

I 100% agree, and I do consider this to be internal implementation detail for the listing modes of "tag" (and "branch"), which may be exposed to the user (by documenting that %(refname:X) is used by default), so perhaps even the flexibility of strip=2 is unwanted.

I know what "remove-standard-prefix" is way too long for the value of X above, but then we can say "the command will error out if you allow your for-each-ref invocation to step outside of the area that has standard prefix to be removed." without having to worry about "what is the sensible thing to do when the prefixes are not what we expect (too short for strip=2 or no match for short=refs/tags/)".

Previous: Jeff KingNext: Jeff King
Message 8 of 19 in “Regression? Ambiguous tags listed as "tags/<foo>"”
  1. Pete HarlanJan 23, 2016
  2. tag: do not show ambiguous tag names as "tags/foo"Jeff King, Jan 24, 2016
  3. Jeff KingJan 24, 2016
  4. Junio C HamanoJan 24, 2016
  5. Jeff KingJan 24, 2016
  6. Eric SunshineJan 24, 2016
  7. Jeff KingJan 25, 2016
  8. Junio C HamanoJan 25, 2016
  9. Jeff KingJan 25, 2016
  10. Karthik NayakJan 25, 2016
  11. Junio C HamanoJan 25, 2016
  12. Jeff KingJan 26, 2016
  13. Jeff KingJan 26, 2016
  14. Junio C HamanoJan 26, 2016
  15. Jeff KingJan 24, 2016
  16. 1/2 t6300: use test_atom for some un-modern testsJeff King, Jan 24, 2016
  17. 2/2 tag: do not show ambiguous tag names as "tags/foo"Jeff King, Jan 24, 2016
  18. Junio C HamanoJan 26, 2016
  19. Karthik NayakJan 26, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.