git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] builtin/receive-pack.c: use parse_options API

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 2, 2016, 08:51 UTC
Message-ID
<xmqqsi0945zs.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<56D67793.5080308@gmail.com>
Sidhant Sharma <tigerkid001@gmail.com> writes:
Show 7 quoted lines
>> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
>>
>>> Thanks. This version looks good to me.
>> I'll queue this with your "Reviewed-by:" to 'pu', just as a
>> Microproject reward ;-).  Given that the program will never see an
>> interactive use from a command line, however, I am not sure if it is
>> worth actually merging it down thru 'next' to 'master'.

Having said that, the resulting code looks more modular in that adding a new option or extending the behaviour of an existing option may be easier with the patch going forward, so after all we might be better off taking it to the production. I'll think about it a bit more and decide.

Thanks.
Previous: Sidhant SharmaNext: Matthieu Moy
Message 11 of 14 in “builtin/receive-pack.c: use parse_options API”
  1. builtin/receive-pack.c: use parse_options APISidhant Sharma [:tk], Mar 1, 2016
  2. Matthieu MoyMar 1, 2016
  3. Sidhant SharmaMar 1, 2016
  4. Matthieu MoyMar 1, 2016
  5. Eric SunshineMar 1, 2016
  6. builtin/receive-pack.c: use parse_options APISidhant Sharma [:tk], Mar 1, 2016
  7. Sidhant SharmaMar 1, 2016
  8. Matthieu MoyMar 1, 2016
  9. Junio C HamanoMar 1, 2016
  10. Sidhant SharmaMar 2, 2016
  11. Junio C HamanoMar 2, 2016
  12. Matthieu MoyMar 2, 2016
  13. Duy NguyenMar 2, 2016
  14. Sidhant SharmaMar 2, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.