Re: What's cooking in git.git (Apr 2016, #08; Fri, 29)

From: Junio C Hamano <gitster@pobox.com>
Date: May 2, 2016, 17:21 UTC
Message-ID: <xmqqshy0v0jd.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160430004741.GA16900@yexl-desktop>

Ye Xiaolong <xiaolong.ye@intel.com> writes:

Show 17 quoted lines

> On Fri, Apr 29, 2016 at 03:04:58PM -0700, Junio C Hamano wrote:
>>* xy/format-patch-base (2016-04-26) 4 commits
>> - format-patch: introduce format.useAutoBase configuration
>> - format-patch: introduce --base=auto option
>> - format-patch: add '--base' option to record base tree info
>> - patch-ids: make commit_patch_id() a public helper function
>>
>> "git format-patch" learned a new "--base" option to record what
>> (public, well-known) commit the original series was built on in
>> its output.
>>
>> Looking close to be ready.
>> ($gmane/292622).
>
> Not quite sure about this status, anything else I need to do other
> than the follow-up patch which to do the enhancement feature
> suggested by Stefan?

I thought that we all agreed that enhancing it with even more heuristics would be nice to have but lack of them does not block what is already in the series from progressing without them?

I was planning to hold this for in 'pu' for a while, until others review them with fresh eyes to make sure there is no have any glaring errors or leaks, and then merge them to 'next' and eventually down to 'master', while accepting follow-up patches on top but as a separate "enhancement" effort.