Re: [PATCH] completion: add "diff.compactionHeuristic" to git config

From: Junio C Hamano <gitster@pobox.com>
Date: Jun 17, 2016, 17:04 UTC
Message-ID: <xmqqshwb21de.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <20160617164223.79500-1-martin.vladev@gmail.com>

Martin Vladev <martinvladev@gmail.com> writes:

> Signed-off-by: Martin Vladev <martin.vladev@gmail.com>
> ---

The reason why existing documentation marks this feature as experimental is because we would eventually want to end the experiment (and use the better heuristics, if the experiment yields one, unconditionally).

Making it more discoverable by completing like this will make it harder to end the experiment, so I am moderately negative on this change.

Thanks.

Show 15 quoted lines

>  contrib/completion/git-completion.bash | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 3402475..55862d6 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -2066,6 +2066,7 @@ _git_config ()
>  		core.whitespace
>  		core.worktree
>  		diff.autorefreshindex
> +		diff.compactionHeuristic
>  		diff.external
>  		diff.ignoreSubmodules
>  		diff.mnemonicprefix