Re: [PATCH v2] gpg-interface: use more status letters

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 28, 2016, 19:59 UTC
Message-ID: <xmqqshsjiyn4.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <c4777ef68059034d7ad4697a06bba3cabbdc9265.1475053649.git.git@drmicha.warpmail.net>

Michael J Gruber <git@drmicha.warpmail.net> writes:

> - Use GNUPGHOME="$HOME/gnupg-home-not-used" just like in other tests (lib).

If you are not using /dev/null, I expected you to do

	. ./test-lib.sh
	GNUPGHOME_saved=$GNPGHOME
        . "$TEST_DIRECTORY/lib-gpg.sh"

and then use

	GNUPGHOME="$GNUPGHOME_saved" git log -1 ...

in the test.

Otherwise, you are not futureproofing your use and only adding to maintenance burden. The gnupg-home-not-used hack may turn out to be a problematic and test-lib.sh may update to point to somewhere else, which will leave your copy still pointing at the old problematic place).

> - Do not parse for signer UID in the ERRSIG case (and test that we do not).

Good.

> - Retreat "rather" addition from the doc: good/valid are terms that we use
>   differently from gpg anyways.

OK.

> +  "X" for a good expired signature, or good signature made by an expired key,

As an attempt to clarify that we cover both EXPSIG and EXPKEYSIG cases, I think this is good enough. I may have phrased the former slightly differently, though: "a good signature that has expired".

I have no strong opinion if we want to stress that we cover both cases, though, which is I think what Ramsay's comment was about.

Thanks.