Re: [PATCH v2] sub-process: print the cmd when a capability is unsupported

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 16, 2017, 21:55 UTC
Message-ID: <xmqqshgri3dv.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <xmqq4lt7pir9.fsf@gitster.mtv.corp.google.com>

Junio C Hamano <gitster@pobox.com> writes:

Show 15 quoted lines

> Ben Peart <peartben@gmail.com> writes:
>
>>> -			warning("external filter requested unsupported filter capability '%s'",
>>> -				p);
>>> +			warning("subprocess '%s' requested unsupported capability '%s'",
>>> +				process->argv[0], p);
>>>   		}
>>>   	}
>>>   
>>>
>>
>> This one is even cleaner.  Thanks Lars for pointing out the fact we
>> already had the cmd name.  Looks good.
>
> Thanks, all.  Will queue.

I still think we would want to turn warning() to die(), but it probably is better to do so in a separate follow-up patch. That will give us a good place to record the reason why the current "just call a warning() and pretend as if nothing bad happend" is wrong.