Re: [PATCH] negotiator/skipping: skip commits during fetch

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 16, 2018, 23:02 UTC
Message-ID: <xmqqsh4irdhk.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180716184401.168576-1-jonathantanmy@google.com>

Jonathan Tan <jonathantanmy@google.com> writes:

Show 14 quoted lines

> Introduce a new negotiation algorithm used during fetch that skips
> commits in an effort to find common ancestors faster. The skips grow
> similarly to the Fibonacci sequence as the commit walk proceeds further
> away from the tips. The skips may cause unnecessary commits to be
> included in the packfile, but the negotiation step typically ends more
> quickly.
>
> Usage of this algorithm is guarded behind the configuration flag
> fetch.negotiationAlgorithm.
>
> Signed-off-by: Jonathan Tan <jonathantanmy@google.com>
> ---
> This is on jt/fetch-pack-negotiator, but also applies cleanly on
> jt/fetch-nego-tip.

Sounds sensible.

Unfortunately, this one is among many others that get hurt by needless semantic conflicts caused by reusing the old function name and changing the function signature to pass the_repository thru some codepaths, without adding transition macros. I am running out of time today as I need some post-office-move clean-ups before getting organized enough, so I expect I won't be able to clean it up and push it out on 'pu' by the end of day today.

Thanks.