git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Bug: git add --patch does not honor "diff.noprefix"

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 9, 2018, 01:30 UTC
Message-ID
<xmqqsgz75vwd.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<c165fc5f-c452-fb2e-8ac3-d2afb12948bc@cweiske.de>
Christian Weiske <cweiske@cweiske.de> writes:
Show 5 quoted lines
> When running "git add -p" on git version 2.19.2 and "diff.noprefix" set
> to true, it still shows the "a/" and "b/" prefixes.
>
> This issue has been reported in 2016 already[1], but is still there in
> 2.19.2.
It is very likely because it is a non-issue.

The reason why prefixes are customizable is to match the convention used to show your patch to others, but the patch to be immediately consumed within an "add -i/-p" session is viewed only by the user, so it is much much lower priority to change the code. I guess the reason why no such change was made is because nobody felt it worth the trouble to change the code to use a non-standard prefix when producing the patch to be shown, and then also change the code to accept a non-standard prefix when using the chosen patch to be applied.

Previous: Christian Weiske
Message 2 of 2 in “Bug: git add --patch does not honor "diff.noprefix"”
  1. Christian WeiskeDec 6, 2018
  2. Junio C HamanoDec 9, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.