Re: [REGRESSION ps/stash-in-c] git stash show -v

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 20, 2019, 01:04 UTC
Message-ID: <xmqqsgviwe2s.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20190319231826.GB32487@hank.intra.tgummerer.com>

Thomas Gummerer <t.gummerer@gmail.com> writes:

Show 11 quoted lines

> Subject: [PATCH] stash: setup default diff output format if necessary
>
> In the scripted 'git stash show' when no arguments are passed, we just
> pass '--stat' to 'git diff'.  When any argument is passed to 'stash
> show', we no longer pass '--stat' to 'git diff', and pass whatever
> flags are passed directly through to 'git diff'.
>
> By default 'git diff' shows the patch output.  So when we a user uses
> 'git stash show -v', they would be shown the diff, because that's the
> default behaviour of 'git diff', but not actually directly triggered
> by passing the '-v'.

A more interesting use case would be not with an otherwise useless "-v" but a real option that does have impact to how "diff" works, e.g. "--patience".