git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] revision: free topo_walk_info before creating a new one in init_topo_walk

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 1, 2019, 16:22 UTC
Message-ID
<xmqqsgm4yq0m.fsf@gitster-ct.c.googlers.com>
In-Reply-To
<46c47a21-d0e1-296f-5563-ae29597f995c@gmail.com>
Derrick Stolee <stolee@gmail.com> writes:
Show 9 quoted lines
> In general I like this change. I'm happy that this was split into a
> method instead of crammed into the block of the "if" below.
>
>> +	clear_author_date_slab(&info->author_date);
>
> The only issue I have is that the author_date slab should not be
> cleared. That is used by more than the topo-walk AND the values for
> author dates will not change between subsequent revision walks. Just
> drop that line and we should be good to go!

Hmph, isn't this merely a performance thing, or would a slab that was once cleared never repopulate upon its second use (i.e. affecting correctness)?

Thanks.
Previous: Derrick StoleeNext: Derrick Stolee
Message 4 of 7 in “revision: clear the topo-walk flags in reset_revision_walk”
  1. 1/2 revision: clear the topo-walk flags in reset_revision_walkMike Hommey, Nov 22, 2019
  2. 2/2 revision: free topo_walk_info before creating a new one in init_topo_walkMike Hommey, Nov 22, 2019
  3. Derrick StoleeNov 27, 2019
  4. Junio C HamanoDec 1, 2019
  5. Derrick StoleeDec 4, 2019
  6. Junio C HamanoDec 4, 2019
  7. Derrick StoleeNov 27, 2019

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.