Re: [PATCH] doc: log takes multiple revision ranges

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 30, 2020, 17:09 UTC
Message-ID: <xmqqsghp93d9.fsf@gitster.c.googlers.com>
In-Reply-To: <51E0F312-E132-4E8E-AFE6-570CB02B4590@gmail.com>

Philippe Blain <levraiphilippeblain@gmail.com> writes:

Show 12 quoted lines

> However, this is really clear in the 'git rev-list' documentation, 
> which uses  '<commit>...' in the synopsis
> and clearly talks about the "set of commits" point of view:
>
>     You can think of this as a set operation. Commits given on the command line form 
>     a set of commits that are reachable from any of them, and then commits reachable 
>     from any of the ones given with ^ in front are subtracted from that set. The remaining 
>     commits are what comes out in the command’s output. Various other options and 
>     paths parameters can be used to further limit the result.
>
> Do you think it would be appropriate that this explanation could somehow also appear 
> in the 'git log' (and maybe also 'gitrevisions') documentation ?

Thanks for finding that paragraph.

I said in my previous message that I didn't think the synopsis and short-help changes were bad, and I hoped that the other hunk of the patch added reference to "git log" page that existed elsewhere to help readers understand what the positive and negative options do. A reference to the "set operation" is exactly the kind of addition I meant I hoped to see.

By the way, I do not write "git log ab/topic-1 cd/topic-2 --not master", but "git log ^master ab/topic-1 cd/topic-2 ef/topic-3" is something I'd quite often write.