Re: Why does git diff-index show intent-to-add file as "Added"?

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 27, 2020, 20:06 UTC
Message-ID: <xmqqsg9zbfhy.fsf@gitster.c.googlers.com>
In-Reply-To: <20201027120943.skmx6c3crbtu335o@yadavpratyush.com>

Pratyush Yadav <me@yadavpratyush.com> writes:

Show 14 quoted lines

> It is `git diff-index --cached HEAD`.
>  
>> What should happen in "diff-index --cached HEAD", I offhand do not
>> know.  "diff-index --cached HEAD" is a request to compare two trees,
>> i.e. the tree that _would_ be produced if you wrote the index out as
>> a tree (i.e. "git write-tree") right now, and the tree of HEAD.  So
>> I think it may be sensible for the command to behave as if the i-t-a
>> path does not even exist in the index when it is run with "--cached";
>> I may be missing some subtleties that require us to do something
>> different, but that is what I would think.
>
> This is what I think too. Can we then treat this as a bug, and work on 
> fixing it? Does any subsystem expert have any comments and/or provide 
> extra context?

I do not think Phillip considers himself an expert in this area, but what he pointed out in the thread

    http://lore.kernel.org/git/xmqqo8kz70xv.fsf@gitster.c.googlers.com/

is worth listening to.