git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] ci: make the whitespace checker more robust

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 3, 2020, 22:02 UTC
Message-ID
<xmqqsg9qp08x.fsf@gitster.c.googlers.com>
In-Reply-To
<pull.778.git.1604418931303.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 9 quoted lines
>     One thing we discussed earlier whether the log should be pasted as
>     pre-formatted text or not, and we fell on the side of not pre-formatting
>     it. However, in my tests, this does not look right
>     [https://github.com/dscho/git/pull/18#issuecomment-721160985], and it 
>     looks much better pre-formatted
>     [https://github.com/dscho/git/pull/18#issuecomment-721167209] (even if
>     we unfortunately lose the direct link to the commit
>     [https://github.com/dscho/git/commit/68317764849af81b17c4b31906da20bdf2c52082]
>     ).

What is shown in the log are lines from the source files that were checked, and we expect our source files are shown and edited in monospace with tabwidth=8, I think it does make sense to force the "pre-formatted" output.

Thanks.
Previous: Johannes Schindelin via GitGitGadget
Message 2 of 2 in “ci: make the whitespace checker more robust”
  1. ci: make the whitespace checker more robustJohannes Schindelin via GitGitGadget, Nov 3, 2020
  2. Junio C HamanoNov 3, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.