git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [ANNOUNCE] git-2.30.0-rc0 - Compile Fails on HPE NonStop

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 16, 2020, 17:27 UTC
Message-ID
<xmqqsg854q5y.fsf@gitster.c.googlers.com>
In-Reply-To
<X9ksfyBujBrYWmAW@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 13 quoted lines
> On Tue, Dec 15, 2020 at 01:08:18PM -0800, Junio C Hamano wrote:
>
>> Elijah Newren <newren@gmail.com> writes:
>> 
>> > Doh, sorry for the bug.  Yeah, that's the exact fix I'd make.  Junio,
>> > do you want to just use the changes you've already got, or would you
>> > like me to submit a patch removing these two 'return's?
>> 
>> Nah, the other half of the reported issue was mine, so let me see if
>> I can quickly whip up a two-patch series.
>
> Thanks, both look OK to me. I probably would have kept "return -1" in
> the setitimer one, but I doubt it really matters much either way.

Yeah, we know that the return value does not matter as nobody looks at it. I just was a bit hesitant to clobber errno with ENOSYS.

Previous: Jeff King
Message 12 of 12 in “Re: [ANNOUNCE] git-2.30.0-rc0 - Compile Fails on HPE NonStop”
  1. Randall S. BeckerDec 14, 2020
  2. Junio C HamanoDec 15, 2020
  3. Jeff KingDec 15, 2020
  4. Randall S. BeckerDec 15, 2020
  5. Elijah NewrenDec 15, 2020
  6. Junio C HamanoDec 15, 2020
  7. Junio C HamanoDec 15, 2020
  8. strmap: make callers of strmap_remove() to call it in void contextJunio C Hamano, Dec 15, 2020
  9. Randall S. BeckerDec 15, 2020
  10. compat-util: pretend that stub setitimer() always succeedsJunio C Hamano, Dec 15, 2020
  11. Jeff KingDec 15, 2020
  12. Junio C HamanoDec 16, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.