Re: What's cooking in git.git (Jan 2021, #02; Fri, 8)
Emily Shaffer <emilyshaffer@google.com> writes:
Show 18 quoted lines
> On Fri, Jan 08, 2021 at 11:22:23AM -0800, Junio C Hamano wrote:
>> * ds/maintenance-part-4 (2021-01-05) 4 commits
>> (merged to 'next' on 2021-01-08 at 1f98c859ea)
>> + maintenance: use Windows scheduled tasks
>> + maintenance: use launchctl on macOS
>> + maintenance: include 'cron' details in docs
>> + maintenance: extract platform-specific scheduling
>>
>> Follow-up on the "maintenance part-3" which introduced scheduled
>> maintenance tasks to support platforms whose native scheduling
>> methods are not 'cron'.
>>
>> Will merge to 'master'.
>
> This series again has troubles running inside a directory with regex
> metachars in the path. Courtesy of Jonathan Nieder, I think this fix
> matches the intent a little better; but if we don't like this, the same
> lines could be diffed just to add --fixed-value instead.
Show 5 quoted lines
> # start registers the repo
> - git config --get --global maintenance.repo "$(pwd)" &&
> + pwd >expect &&
> + git config --get --global maintenance.repo >actual &&
> + test_cmp expect actual &&
> Before this patch, the test said "Is there something configured in
> maintenance.repo that looks like $PWD?" and after this patch, the test
> says, "Does the config in maintenance.repo look like $PWD?" - so it is
> not quite semantically identical but I think may be clearer.
Sounds sensible. Derrick (CC'ed), thoughts?
Junio C Hamano <gitster@pobox.com>