Re: git archive setting user and group

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 22, 2021, 22:29 UTC
Message-ID: <xmqqsg6s61x2.fsf@gitster.c.googlers.com>
In-Reply-To: <cef51cd3-c6b5-ed24-f695-83be3a6743b4@web.de>

René Scharfe <l.s.r@web.de> writes:

Show 12 quoted lines

> Am 22.01.21 um 21:40 schrieb Jason Pyeron:
> ...
>>         xsnprintf(header->uid, sizeof(header->uid), "%07o", 0);
>>         xsnprintf(header->gid, sizeof(header->gid), "%07o", 0);
>>         strlcpy(header->uname, "root", sizeof(header->uname));
>>         strlcpy(header->gname, "root", sizeof(header->gname));
>
> Adding support for using a custom user and group should be easy.  Is
> this just a cosmetic thing?  Regular users would ignore the user info in
> the archive, and root should not be used for extracting, and on systems
> that don't have a logwatch user this wouldn't make a difference anyway,
> right?

I am not particularly interested in cosmetics, but it probably is OK to make uname/gname overridable. I do not see any point in uid/gid numeric values overridable, though. Just like user names and group names do not name the same user and group on every machine, uid/gid are even less so.