Re: [PATCH 1/2] send-pack: complain about "expecting report" with --helper-status

From: Junio C Hamano <gitster@pobox.com>
Date: Oct 18, 2021, 20:26 UTC
Message-ID: <xmqqsfwyuljl.fsf@gitster.g>
In-Reply-To: <YW3OcxqcOsY9AFQ8@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 15 quoted lines

> diff --git a/builtin/send-pack.c b/builtin/send-pack.c
> index 8932142312..69c432ef1a 100644
> --- a/builtin/send-pack.c
> +++ b/builtin/send-pack.c
> @@ -87,6 +87,10 @@ static void print_helper_status(struct ref *ref)
>  			break;
>  
>  		case REF_STATUS_EXPECTING_REPORT:
> +			res = "error";
> +			msg = "expecting report";
> +			break;
> +
>  		default:
>  			continue;
>  		}

That is obviously correct, minimum and surprisingly simple ;-)

Thanks.