git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] stash: show error message when lockfile is present

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 8, 2021, 20:05 UTC
Message-ID
<xmqqsfw6tnu7.fsf@gitster.g>
In-Reply-To
<211108.868rxyfote.gmgdl@evledraar.gmail.com>
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> The "quiet" here is orthagonal, it's to disable the chatty output from
> read-cache.c.

It shouldn't be. read-cache.c may want to report errors and progresses, and among the errors it may not include lock-related things. If the change were to (1) extend the flag word to make it more uniform, so that it does not special case ONLY the lock-related errors, and to (2) figure out how to grab richer diagnoses out of the lower level API functions, and to (3) reduce the messages issued by the lower-level API functions and have it callers' responsibility to give the messages, that would have been palatable, but the patch as posted goes totally the opposite direction on all these points.

Yuck.
Previous: Ævar Arnfjörð BjarmasonNext: Birk Tjelmeland
Message 7 of 8 in “stash: show error message when lockfile is present”
  1. stash: show error message when lockfile is presentBirk Tjelmeland, Nov 7, 2021
  2. Taylor BlauNov 8, 2021
  3. Taylor BlauNov 8, 2021
  4. Junio C HamanoNov 8, 2021
  5. Taylor BlauNov 8, 2021
  6. Ævar Arnfjörð BjarmasonNov 8, 2021
  7. Junio C HamanoNov 8, 2021
  8. Birk TjelmelandNov 8, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.