Re: [PATCH 2/3] t1405: mark test that checks existence as REFFILES

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 1, 2022, 22:11 UTC
Message-ID: <xmqqsft2b5jl.fsf@gitster.g>
In-Reply-To: <220201.861r0m9t8n.gmgdl@evledraar.gmail.com>

Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:

> We could surely add magic record types, but how would such a dance be
> performed while keeping compatibility with existing JGit clients?

Yes. It is exactly the point of the question I asked. If it is simple and easy to add such a new type that is ignored/skipped by existing clients, then we can go that route. If it is simple and easy to add a new bit per ref that existing clients would not barf, we can use that as an alternative implementation strategy.

And if neither is possible, and there is no other viable third way, then what I wrote in the part you omitted from your quote still stands, which was:

>> It is probably a lot more sensible to fail refs_create_reflog() and
>> safe_create_reflog() (which is a thin wrapper around the former), if
>> we cannot implement "a reflog can exist and have no entries yet"
>> semantics.