Re: [PATCH] help: reword explanation line for developer interfaces

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 16, 2022, 16:19 UTC
Message-ID: <xmqqsfkri96i.fsf@gitster.g>
In-Reply-To: <pull.1330.git.git.1663333529294.gitgitgadget@gmail.com>

"Fangyi Zhou via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 7 quoted lines

> From: Fangyi Zhou <me@fangyi.io>
>
> Signed-off-by: Fangyi Zhou <me@fangyi.io>
> ---
>     help: reword explanation line for developer interfaces
>     
>     Signed-off-by: Fangyi Zhou me@fangyi.io

> -	{ CAT_developerinterfaces, N_("Developer-facing file file formats, protocols and interfaces") },
> +	{ CAT_developerinterfaces, N_("Developer-facing file formats, protocols and other interfaces") },

Yuck.  Thanks for catching this.

Show 14 quoted lines

>  	{ 0, NULL }
>  };
>  
> diff --git a/t/t0012-help.sh b/t/t0012-help.sh
> index 4ed2f242eb2..dbfc5c82676 100755
> --- a/t/t0012-help.sh
> +++ b/t/t0012-help.sh
> @@ -231,7 +231,7 @@ test_expect_success "'git help -a' section spacing" '
>  
>  	User-facing repository, command and file interfaces
>  
> -	Developer-facing file file formats, protocols and interfaces
> +	Developer-facing file formats, protocols and other interfaces
>  	EOF

Apparently the writer of the test was not doing a good job; and of course the reviewers, too X-.

These all came from 844739ba (git docs: add a category for file formats, protocols and interfaces, 2022-08-04), as a part of a large series.

Will queue.