git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 2/2] completion: commit: complete trailers tokens more robustly

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 13, 2023, 00:34 UTC
Message-ID
<xmqqsf7ikj1s.fsf@gitster.g>
In-Reply-To
<9cb33c20294e096f5345fb1ea9d80a23e899ae6f.1694539827.git.gitgitgadget@gmail.com>
"Philippe Blain via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 15 quoted lines
> From: Philippe Blain <levraiphilippeblain@gmail.com>
>
> In the previous commit, we added support for completing configured
> trailer tokens in 'git commit --trailer'.
>
> Make the implementation more robust by:
>
> - using '__git' instead of plain 'git', as the rest of the completion
>   script does
> - using a stricter pattern for --get-regexp to avoid false hits
> - using 'cut' and 'rev' instead of 'awk' to account for tokens including
>   dots.
>
> Signed-off-by: Philippe Blain <levraiphilippeblain@gmail.com>
> ---
Thanks, both, for a quick fix.
Queued.
Previous: Philippe Blain via GitGitGadgetNext: ZheNing Hu
Message 8 of 9 in “completion: commit: complete configured trailer tokens”
  1. completion: commit: complete configured trailer tokensPhilippe Blain via GitGitGadget, Sep 7, 2023
  2. Junio C HamanoSep 7, 2023
  3. Martin ÅgrenSep 11, 2023
  4. Philippe BlainSep 12, 2023
  5. 0/2 completion: commit: complete configured trailer tokensPhilippe Blain via GitGitGadget, Sep 12, 2023
  6. 1/2 completion: commit: complete configured trailer tokensPhilippe Blain via GitGitGadget, Sep 12, 2023
  7. 2/2 completion: commit: complete trailers tokens more robustlyPhilippe Blain via GitGitGadget, Sep 12, 2023
  8. Junio C HamanoSep 13, 2023
  9. ZheNing HuSep 16, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.