Re: [PATCH 1/1] attr: add builtin objectmode values support
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 16, 2023, 06:17 UTC
- Message-ID
- <xmqqsf56ql14.fsf@gitster.g>
- In-Reply-To
- <20231116054437.2343549-1-jojwang@google.com>
Joanna Wang <jojwang@google.com> writes:
> t/#t1700-split-index.sh# | 547 ++++++++++++++++++++++++++++++++
This was added by mistake and we can safely ignore it? IOW, is everything else in the patch, other than the addition of this path, what you intended to send out?
Other than the removal of that file, I locally applied the following fix-up while checking the difference relative to the previous iteration. Other than these, the updated version looked very clear and nicely done.
Thanks.
t/t0003-attributes.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/t/t0003-attributes.sh b/t/t0003-attributes.sh index 86f8681570..774b52c298 100755 --- a/t/t0003-attributes.sh +++ b/t/t0003-attributes.sh @@ -580,12 +580,13 @@ test_expect_success 'builtin object mode attributes work (dir and regular paths) ' test_expect_success POSIXPERM 'builtin object mode attributes work (executable)' ' - >exec && chmod +x exec && + >exec && + chmod +x exec && attr_check_object_mode exec 100755 ' test_expect_success SYMLINKS 'builtin object mode attributes work (symlinks)' ' - >to_sym ln -s to_sym sym && + ln -s to_sym sym && attr_check_object_mode sym 120000 '