Re: [PATCH] t/README: mention test files are make targets

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 25, 2024, 19:01 UTC
Message-ID: <xmqqsf0ejftz.fsf@gitster.g>
In-Reply-To: <CAPx1GvcPEeC3HTdb4bUYASz-t=a7Z2MEUamB4QyO44y4MRy6Pw@mail.gmail.com>

Chris Torek <chris.torek@gmail.com> writes:

Show 14 quoted lines

> On Mon, Mar 25, 2024 at 2:49 AM Junio C Hamano <gitster@pobox.com> wrote:
>> As long as we do not use these $(T) files as an input to some other
>> thing and list them as the dependencies, we are OK, though.
>
> You could (maybe later / at need) stop listing them as `.PHONY` and
> instead use:
>
>     $(T)::
>         sh -c ./$@
>
> or similar, so that some $(T) *can* be an input. Note that this requires
> using double-colon rules earlier to build the test.
>
> I wouldn't do this without a pretty strong reason though.

Me neither.

I personally think a target that is marked as .PHONY and does not use double-colon rule is a bug by itself but that is a separate story.

In any case, just to avoid leaving the thread hanging, I'll take the patch as is, as it documents a useful trick in the status quo.

Thanks, all.