Re: [PATCH] do not set GIT_TEST_MAINT_SCHEDULER where it does not matter

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 29, 2024, 05:38 UTC
Message-ID: <xmqqsf09vbqf.fsf@gitster.g>
In-Reply-To: <CAPig+cStHRX-wZKwdcO33wCjd4UU3MO-rVisyOFZ1vPbGaN51Q@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

Show 7 quoted lines

> Clearly the idea was to protect the scheduler-configuration of the
> person running the test in the event that the test author forgot to
> set GIT_TEST_MAINT_SCHEDULER to one of the legitimate "testing values"
> before invoking a "destructive" command, such as `git maintenance
> start`. By defaulting to `none:exit 1`, the problem would be caught
> and reported before any damage could be done to the configuration of
> the person running the tests.

Yeah, if the variable were exported. So I am OK with a fix in the opposite direction.