Re: [PATCH 0/3] maintenance: configure credentials to be silent

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 23, 2024, 16:24 UTC
Message-ID: <xmqqsetq49tj.fsf@gitster.g>
In-Reply-To: <5114e7fa-7858-458a-bc5d-5c82ea663a48@gmail.com>

Derrick Stolee <stolee@gmail.com> writes:

Show 12 quoted lines

> On 9/20/24 5:56 PM, Junio C Hamano wrote:
>> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
>> 
>>> Add a new configuration value, 'credential.interactive', to specify to the
>>> credential helper that it should not prompt for user interaction. This
>>> option has been respected by Git Credential Manager since 2020 [1], so this
>>> is now presenting it as an official Git config value.
>> So, the other helpers are also supposed to check for the variable
>> and fail when it has to go interactive now.
>
> I would hold off from saying "supposed to" but Git is definitely hinting
> towards that behavior.

I would too. I didn't mean "they were behaving correctly, but we changed the rules from under them and they need to be fixed". With or without your patch, they would try to go interactive and make the process get stuck, until they start to check if they should refrain from going interactive. With your patch, they have a way to do that check in a documented way.

Show 6 quoted lines

> Perhaps I'm just hung up on the idea that we are not adding a new wrinkle
> to the "contract" but recommending a good thing that was previously not part
> of the interaction.
>
> Thanks,
> -Stolee