git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] cmake: generalize the handling of the `UNIT_TEST_OBJS` list

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 24, 2024, 01:58 UTC
Message-ID
<xmqqsetpx16k.fsf@gitster.g>
In-Reply-To
<pull.1797.git.1726687769585.gitgitgadget@gmail.com>

"Johannes Schindelin via GitGitGadget" <gitgitgadget@gmail.com> writes:

Show 5 quoted lines
> With a4f50bb1e9b (t/unit-tests: introduce reftable library, 2024-09-16),
> however, the `UNIT_TEST_OBJS` list became a trio, and the CMake
> definition has to be adjusted again. Now that we can use the
> `parse_makefile_for_sources()` function without many complications,
> let's do that.

Am I correct to understand that it is not "trio"-ness (has three things) that makes the approach feasible, but the fact that all three things are concrete values?

The longer-term aspiration is to migrate everything to clar-based unit tests, so the list will hopefully keep getting shorter and then become empty (https://lore.kernel.org/git/Zt_lLsnylKJ9uoqj@pks.im/).

Will queue.  Thanks.
Previous: Johannes Schindelin via GitGitGadgetNext: Johannes Schindelin
Message 2 of 4 in “cmake: generalize the handling of the `UNIT_TEST_OBJS` list”
  1. cmake: generalize the handling of the `UNIT_TEST_OBJS` listJohannes Schindelin via GitGitGadget, Sep 18, 2024
  2. Junio C HamanoSep 24, 2024
  3. Johannes SchindelinSep 29, 2024
  4. Junio C HamanoSep 30, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.