Re: What's cooking in git.git (Feb 2025, #01; Tue, 4)

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 6, 2025, 00:04 UTC
Message-ID: <xmqqseoskkf4.fsf@gitster.g>
In-Reply-To: <xmqq7c64nn4o.fsf@gitster.g>

Junio C Hamano <gitster@pobox.com> writes:

Show 11 quoted lines

> Patrick Steinhardt <ps@pks.im> writes:
>
>> One topic that I miss in the cover letter is [1]. You probably forgot to
>> pick it up :)
>>
>> [1]: <20250125-b4-pks-reftable-win32-in-use-errors-v1-1-356dbc783b4f@pks.im>
>
> OK, I was wondering if we are going to rethink after seeing some
> comments but with blessing by j6t [*], I guess this is fine.
>
> [*]: <37c14379-68e4-4c52-a08d-b78c7797ef26@kdbg.org>

Wait. This works by futzing with unlink() call that is imported via <git-compat-util.h> which you got rid of in a separate topic, and given the overall theme of sans-compat-util topic, I do not think you want to include <compat/mingw.h> either directly or indirectly (via <git-compat-util.h> as we used to), either.

So where would that leave us...?