Re: [PATCH v2 1/5] builtin/history: perform revwalk checks before asking for user input

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 13, 2026, 17:20 UTC
Message-ID: <xmqqseb4mufi.fsf@gitster.g>
In-Reply-To: <20260213-b4-pks-history-dry-run-v2-1-756ac376e9e5@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

> Adapt one of the tests that is expected to fail because of this check
> to use false(1) as editor. If the editor had been executed by Git, it
> would fail with the error message "Aborting commit as launching the
> editor failed."

I very much appreciate this new description. OK, we expect the test to fail due to the check in question, and ensure that the editor is not invoked, by looking at the error message and making sure it is not the abort due to the editor returning false.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.