Re: [PATCH v3 0/4] completion: add support for 'git history'

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 19, 2026, 20:18 UTC
Message-ID: <xmqqse49uanx.fsf@gitster.g>
In-Reply-To: <aoWP3TYq5rNjUx7S@pks.im>

Patrick Steinhardt <ps@pks.im> writes:

Show 12 quoted lines

> On Thu, Aug 13, 2026 at 09:05:01PM +0200, Vincent Mailhol wrote:
>> Changes in v3:
>> 
>>   - Ignore the split "<option> <value>" syntax for options that take
>>     arguments. This simplifies revision detection and avoids hard-coding
>>     option names.
>>   - Test that options are not completed before a subcommand.
>
> I'm happy with this version and I think it's a good base to build on
> going forward. Thanks!
>
> Patrick

Thanks, both.

I'll prepare an evil-merge to rewrite the test to add 'squash' to the candidatesto adjust to the subcommand addition to another topic in-flight brings in when merging these patches to 'seen'.

Vincent, this is strictly FYI. You do not need to rebase on top of the other topic, until I and/or the author of the other topic ask you.

Thanks.