Re: [PATCH 1/2] builtin/stash: remove unused header

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 21, 2026, 15:10 UTC
Message-ID: <xmqqse32od1c.fsf@gitster.g>
In-Reply-To: <b6798c8a25993913d2ba13b8f3b08d602364ca44.1789853192.git.ben.knoble@gmail.com>

"D. Ben Knoble" <ben.knoble@gmail.com> writes:

> Clang complains that oid-array.h is unused. Certainly none of the
> oid_array* functions, types, etc., are used, and the

> transitively-included hash.h declarations are used but covered by a
> pre-existing direct #include of hash.h.

Good thing to make sure.

And the correctness of the patch can easily be validated, which makes this kind of patch no-brainer to accept ;-)

Thanks.

Show 18 quoted lines

>
> Signed-off-by: D. Ben Knoble <ben.knoble@gmail.com>
> ---
>  builtin/stash.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/builtin/stash.c b/builtin/stash.c
> index 7a9843413b..dfea2d2c4c 100644
> --- a/builtin/stash.c
> +++ b/builtin/stash.c
> @@ -31,7 +31,6 @@
>  #include "reflog.h"
>  #include "reflog-walk.h"
>  #include "add-interactive.h"
> -#include "oid-array.h"
>  #include "commit.h"
>  
>  #define INCLUDE_ALL_FILES 2