Re: [PATCH v4 0/7] stash creation: avoid unecessary index loads and refreshes
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 5, 2026, 21:52 UTC
- Message-ID
- <xmqqse1fq72m.fsf@gitster.g>
- In-Reply-To
- <cover.1792767794.git.phillip.wood@dunelm.org.uk>
Phillip Wood <phillip.wood123@gmail.com> writes:
Show 5 quoted lines
> Changes since V3: > - Avoid implict cast of enum create_result to int in create_stash() > - Fixed enum initializers > - Use switch() rather than if() when checking enum create_result > return values
These changes look very good.
> 5: de5e0c196a9 = 5: b62d3d080a8 stash create: rework temporary index creation > 6: 61e4ce22a0f = 6: 8c54c118307 stash create: remove unnecessary index load and refresh > 7: a486a625c95 = 7: f61ebbf9a3e stash: simplify reset_tree() function signature
I'll have another look at latter half of the series which I didn't comment on in my earlier review separately.
Thanks.