Re: ref-format checking regression

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 27, 2012, 15:06 UTC
Message-ID: <xmqqr4v99pu5.fsf@junio.mtv.corp.google.com>
In-Reply-To: <20120427115000.GA8126@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 11 quoted lines

> I upgraded git on a machine recently, and it created problems for a repo
> with a bogus character in a ref name.  Older versions of git never
> complained about it. Newer ones, containing your dce4bab ("add_ref():
> verify that the refname is formatted correctly") do. That's fine; it's
> bogus and git _should_ complain about it.
> 
> However, recovering from the situation is unnecessarily hard, ...
> ...
> I seem to recall discussing this format-tightening and trying to be sure
> that users were left with a way forward for fixing their repos. But I
> can't find the discussion, and I don't recall any conclusion we came to.

I haven't dug the archive but I do recall pointing many issues out around the theme "be liberal in what you accept and strict in what you produce" on this topic, and loosening one or two showstoppers during the review cycle, but obviously we did not catch all of them.

Michael?