Re: [PATCH] format-patch: print in-body "From" only when needed

From: Junio C Hamano <gitster@pobox.com>
Date: Sep 20, 2013, 21:06 UTC
Message-ID: <xmqqr4cjp5j0.fsf@gitster.dls.corp.google.com>
In-Reply-To: <20130920191226.GB31170@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

> So I think it should be possible to fix our internal consumers 
> ... I'm a little wary
> of external consumers that might get confused by it.

Yeah, thanks for a good summary of analysis. I agree that it would be doable, but it is dubious if it is worth it.

Show 15 quoted lines

>
> ---
> diff --git a/builtin/log.c b/builtin/log.c
> index 77d0f5f..77564fd 100644
> --- a/builtin/log.c
> +++ b/builtin/log.c
> @@ -1235,6 +1235,8 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
>  		rev.no_inline = 1;
>  	}
>  
> +	from = xstrdup(git_committer_info(IDENT_NO_DATE));
> +
>  	/*
>  	 * Parse the arguments before setup_revisions(), or something
>  	 * like "git format-patch -o a123 HEAD^.." may fail; a123 is