Re: [PATCH] environment: enable core.preloadindex by default
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jun 5, 2014, 22:59 UTC
- Message-ID
- <xmqqr433q7x0.fsf@gitster.dls.corp.google.com>
- In-Reply-To
- <CACbrTHdoA3UgoXOMVeB2ST_y-JzA2FZM7s8_uwG8C3D29WZK=Q@mail.gmail.com>
Steve Hoelzer <shoelzer@gmail.com> writes:
Show 8 quoted lines
> There is consensus that the default should change because it will > benefit nearly all users (some just a little, but some a lot). > See [1] and replies. > > [1]: http://git.661346.n2.nabble.com/git-status-takes-30-seconds-on-Windows-7-Why-tp7580816p7580853.html > > Signed-off-by: Steve Hoelzer <shoelzer@gmail.com> > ---
The patch is whitespace damaged, and the log message was unusable without referring to an external site. Both locally fixed and queued.
Thanks.
Show 33 quoted lines
> Documentation/config.txt | 4 ++-- > environment.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/Documentation/config.txt b/Documentation/config.txt > index 1932e9b..4b3d965 100644 > --- a/Documentation/config.txt > +++ b/Documentation/config.txt > @@ -613,9 +613,9 @@ core.preloadindex:: > + > This can speed up operations like 'git diff' and 'git status' especially > on filesystems like NFS that have weak caching semantics and thus > -relatively high IO latencies. With this set to 'true', Git will do the > +relatively high IO latencies. When enabled, Git will do the > index comparison to the filesystem data in parallel, allowing > -overlapping IO's. > +overlapping IO's. Defaults to true. > > core.createObject:: > You can set this to 'link', in which case a hardlink followed by > diff --git a/environment.c b/environment.c > index 5c4815d..1c686c9 100644 > --- a/environment.c > +++ b/environment.c > @@ -71,7 +71,7 @@ unsigned long pack_size_limit_cfg; > char comment_line_char = '#'; > > /* Parallel index stat data preload? */ > -int core_preload_index = 0; > +int core_preload_index = 1; > > /* This is set by setup_git_dir_gently() and/or git_default_config() */ > char *git_work_tree_cfg;